Don't show the view account button if a cellular network is not connected.

Don't show the view account button if a cellular network is not connected.
If a cellular network is not connected, we don't have an active network to pull the account URL from.

Also adding per-file owners in MTV for internet_options_handler.*

TBR'ing Nikita for the owner's review since this needs to get merged to 25.

R=stevenjb@chromium.org,benchan@chromium.org
TBR=nkostylev@chromium.org
BUG=176200
TEST=View account button should not be visible if not connected to the cellular network.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182789

[Ben Chan, 2013-02-15 00:09:41]

https://codereview.chromium.org/12256049/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/12256049/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1568: //
active network to pull the account URL info from.
Is the cellular connection really necessary? I think we can view the account
over WiFi.

[rkc, 2013-02-15 00:10:43]

On 2013/02/15 00:09:45, Ben Chan wrote:

I've updated the issue to explain why we are removing the button completely.

[stevenjb, 2013-02-15 00:12:53]

https://codereview.chromium.org/12256049/diff/6001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/12256049/diff/6001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1568: //
active network to pull the account URL info from.
Shouldn't we check for cros->connected_network() instead? i.e. does the
connection need to be cellular?

[rkc, 2013-02-15 00:19:59]

https://codereview.chromium.org/12256049/diff/6001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/12256049/diff/6001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1568: //
active network to pull the account URL info from.
On 2013/02/15 00:12:53, stevenjb (chromium) wrote:
> Shouldn't we check for cros->connected_network() instead? i.e. does the
> connection need to be cellular?

We're specifically checking if this cellular network (that we're populating
details for) is connected because when the user clicks View Account on this
page, he'll be pulling the URL from the active cellular network.

If we don't have a network connected, we really can't show an account URL since
GSM devices can cannot to different networks, which may have different account
URL's.

Of course for CDMA we can hack this, but I'd prefer to simply just not show the
View Account button if we aren't connected to a network, since it's cleaner.

[stevenjb, 2013-02-15 00:22:52]

lgtm

https://codereview.chromium.org/12256049/diff/6001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/12256049/diff/6001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1568: //
active network to pull the account URL info from.
On 2013/02/15 00:19:59, Rahul Chaturvedi wrote:
> On 2013/02/15 00:12:53, stevenjb (chromium) wrote:
> > Shouldn't we check for cros->connected_network() instead? i.e. does the
> > connection need to be cellular?
> 
> We're specifically checking if this cellular network (that we're populating
> details for) is connected because when the user clicks View Account on this
> page, he'll be pulling the URL from the active cellular network.
> 
> If we don't have a network connected, we really can't show an account URL
since
> GSM devices can cannot to different networks, which may have different account
> URL's.
> 
> Of course for CDMA we can hack this, but I'd prefer to simply just not show
the
> View Account button if we aren't connected to a network, since it's cleaner.
> 

OK, if it makes sense to ben, it's good enough for me.

[stevenjb, 2013-02-15 00:22:53]

lgtm

[commit-bot: I haz the power, 2013-02-15 00:29:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/12256049/6001

[commit-bot: I haz the power, 2013-02-15 14:03:07]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-02-15 18:55:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/12256049/6001

[commit-bot: I haz the power, 2013-02-15 19:38:37]

Change committed as 182789