Chromium Code Reviews| Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc |
| diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc |
| index 9e75a4c44abd2faef4ec8dc0bee9bce3d47e685a..d8e72f2e5aa7732d9a71f69f25396ed8dceaaa3b 100644 |
| --- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc |
| +++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc |
| @@ -1561,9 +1561,11 @@ void InternetOptionsHandler::SetCellularButtonsVisibility( |
| } else { |
| const chromeos::MobileConfig::Carrier* carrier = |
| chromeos::MobileConfig::GetInstance()->GetCarrier(carrier_id); |
| - if (carrier && carrier->show_portal_button()) { |
| - // This will trigger BuyDataPlanCallback() so that |
| - // chrome://mobilesetup/ will open carrier specific portal. |
| + if (carrier && carrier->show_portal_button() && cellular->connected()) { |
| + // This will trigger BuyDataPlanCallback() so that chrome://mobilesetup/ |
| + // will open carrier specific portal. If the cellular network is not |
| + // connected, don't show the view account button since we don't have an |
| + // active network to pull the account URL info from. |
|
stevenjb
2013/02/15 00:12:53
Shouldn't we check for cros->connected_network() i
rkc
2013/02/15 00:19:59
We're specifically checking if this cellular netwo
stevenjb
2013/02/15 00:22:52
OK, if it makes sense to ben, it's good enough for
|
| dictionary->SetBoolean(kTagShowViewAccountButton, true); |
| } |
| } |