Don't show the view account button if a cellular network is not connected.

chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/internet_options_handler.h"
 
 #include <ctype.h>
 
 #include <map>
 #include <string>
@@ skipping 1543 matching lines @@
       kTagDisableConnectButton,
       cellular->activation_state() == chromeos::ACTIVATION_STATE_ACTIVATING ||
           cellular->connecting());
 
   if (cellular->activation_state() != chromeos::ACTIVATION_STATE_ACTIVATING &&
       cellular->activation_state() != chromeos::ACTIVATION_STATE_ACTIVATED) {
     dictionary->SetBoolean(kTagShowActivateButton, true);
   } else {
     const chromeos::MobileConfig::Carrier* carrier =
         chromeos::MobileConfig::GetInstance()->GetCarrier(carrier_id);
-    if (carrier && carrier->show_portal_button()) {
-      // This will trigger BuyDataPlanCallback() so that
-      // chrome://mobilesetup/ will open carrier specific portal.
+    if (carrier && carrier->show_portal_button() && cellular->connected()) {
+      // This will trigger BuyDataPlanCallback() so that chrome://mobilesetup/
+      // will open carrier specific portal. If the cellular network is not
+      // connected, don't show the view account button since we don't have an
+      // active network to pull the account URL info from.

[stevenjb, 2013/02/15 00:12:53]

Shouldn't we check for cros->connected_network() instead? i.e. does the
connection need to be cellular?

[rkc, 2013/02/15 00:19:59]

We're specifically checking if this cellular network (that we're populating
details for) is connected because when the user clicks View Account on this
page, he'll be pulling the URL from the active cellular network.

If we don't have a network connected, we really can't show an account URL since
GSM devices can cannot to different networks, which may have different account
URL's.

Of course for CDMA we can hack this, but I'd prefer to simply just not show the
View Account button if we aren't connected to a network, since it's cleaner.

[stevenjb, 2013/02/15 00:22:52]

OK, if it makes sense to ben, it's good enough for me.

       dictionary->SetBoolean(kTagShowViewAccountButton, true);
     }
   }
 }
 
 gfx::NativeWindow InternetOptionsHandler::GetNativeWindow() const {
   // TODO(beng): This is an improper direct dependency on Browser. Route this
   // through some sort of delegate.
   Browser* browser =
       chrome::FindBrowserWithWebContents(web_ui()->GetWebContents());
@@ skipping 263 matching lines @@
 
   dictionary->SetBoolean(kTagWimaxEnabled, cros_->wimax_enabled());
   dictionary->SetBoolean(kTagWimaxAvailable, cros_->wimax_available());
   dictionary->SetBoolean(kTagWimaxBusy, cros_->wimax_busy());
   // TODO(kevers): The use of 'offline_mode' is not quite correct.  Update once
   // we have proper back-end support.
   dictionary->SetBoolean(kTagAirplaneMode, cros_->offline_mode());
 }
 
 }  // namespace options