Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225363002: Move GrProcessorDataManager to GrMemoryPool (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrProcessorDataManager to GrMemoryPool TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/5b4f05f709d2b45f1b61e613a4fd073c31fa66d8

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tidy #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -20 lines) Patch
M include/gpu/GrPaint.h View 1 2 chunks +10 lines, -7 lines 0 comments Download
M include/gpu/GrProcessorDataManager.h View 1 2 3 4 1 chunk +38 lines, -1 line 0 comments Download
M src/gpu/GrPaint.cpp View 1 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 4 3 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 2 4 3 chunks +7 lines, -1 line 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1230023003 Patch 60001

Messages

Total messages: 15 (7 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-09 19:27:23 UTC) #2
robertphillips
lgtm + question https://codereview.chromium.org/1225363002/diff/60001/src/gpu/GrPipelineBuilder.cpp File src/gpu/GrPipelineBuilder.cpp (right): https://codereview.chromium.org/1225363002/diff/60001/src/gpu/GrPipelineBuilder.cpp#newcode17 src/gpu/GrPipelineBuilder.cpp:17: Do we still need this ctor? ...
5 years, 5 months ago (2015-07-10 13:54:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225363002/60001
5 years, 5 months ago (2015-07-10 14:00:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1993) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 14:01:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225363002/80001
5 years, 5 months ago (2015-07-10 14:18:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1016)
5 years, 5 months ago (2015-07-10 14:19:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225363002/80001
5 years, 5 months ago (2015-07-10 14:25:44 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 14:26:24 UTC) #15
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5b4f05f709d2b45f1b61e613a4fd073c31fa66d8

Powered by Google App Engine
This is Rietveld 408576698