Modify GrClipMaskManager to reflect logical constness

Modify GrClipMaskManager to reflect logical constness

TBR=bsalomon@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5e6ba21f0722fea6b2f95b9d166d7601ffab18bf

[joshualitt, 2015-07-09 20:22:57]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-07-09 20:22:58]

ptal

[joshualitt, 2015-07-09 20:55:41]

On 2015/07/09 20:22:58, joshualitt wrote:
> ptal

ugh, nevermind I don't think we can do this.

[joshualitt, 2015-07-10 13:28:27]

On 2015/07/09 20:55:41, joshualitt wrote:
> On 2015/07/09 20:22:58, joshualitt wrote:
> > ptal
> 
> ugh, nevermind I don't think we can do this.

Actually, I think we can land this patch, but we'll only be able to propagate
the constness so far up the stack for the time being.

[robertphillips, 2015-07-10 14:34:10]

https://codereview.chromium.org/1230023003/diff/40001/include/gpu/GrProcessor...
File include/gpu/GrProcessorDataManager.h (right):

https://codereview.chromium.org/1230023003/diff/40001/include/gpu/GrProcessor...
include/gpu/GrProcessorDataManager.h:28: private:
I'm not crazy about 'height' here

https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrClipMaskManag...
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrClipMaskManag...
src/gpu/GrClipMaskManager.cpp:77: 
Does the parameter to getPathRenderer have to be a pointer ?

https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrPipelineBuild...
File src/gpu/GrPipelineBuilder.h (right):

https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:417: public:
Will this entire ctor fit on one line ?

https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:436: if (ds) {
currentHeight -> numDataFrames, dataPlaceHolder, restoreMarker ?

[joshualitt, 2015-07-10 16:02:17]

On 2015/07/10 14:34:10, robertphillips wrote:
>
https://codereview.chromium.org/1230023003/diff/40001/include/gpu/GrProcessor...
> File include/gpu/GrProcessorDataManager.h (right):
> 
>
https://codereview.chromium.org/1230023003/diff/40001/include/gpu/GrProcessor...
> include/gpu/GrProcessorDataManager.h:28: private:
> I'm not crazy about 'height' here
> 
>
https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrClipMaskManag...
> File src/gpu/GrClipMaskManager.cpp (right):
> 
>
https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrClipMaskManag...
> src/gpu/GrClipMaskManager.cpp:77: 
> Does the parameter to getPathRenderer have to be a pointer ?
> 
>
https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrPipelineBuild...
> File src/gpu/GrPipelineBuilder.h (right):
> 
>
https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrPipelineBuild...
> src/gpu/GrPipelineBuilder.h:417: public:
> Will this entire ctor fit on one line ?
> 
>
https://codereview.chromium.org/1230023003/diff/40001/src/gpu/GrPipelineBuild...
> src/gpu/GrPipelineBuilder.h:436: if (ds) {
> currentHeight -> numDataFrames, dataPlaceHolder, restoreMarker ?

feedback incorporated, feel free to sit on this for a bit, though I think its a
good change.

[robertphillips, 2015-07-10 17:25:45]

lgtm + comment requests

We may want to hold off landing until Monday (or, at least, discuss with Stephan
& Heather).

https://codereview.chromium.org/1230023003/diff/60001/include/gpu/GrProcessor...
File include/gpu/GrProcessorDataManager.h (right):

https://codereview.chromium.org/1230023003/diff/60001/include/gpu/GrProcessor...
include/gpu/GrProcessorDataManager.h:33: uint32_t currentSaveMarker() const {
return 0; }
maybe restoreToSaveMarker ?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrDrawTarget.cp...
src/gpu/GrDrawTarget.cpp:506: 
Can this guy take a "const GrPipelineBuilder&" ?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrDrawTarget.h#...
src/gpu/GrDrawTarget.h:342: 
rm virtual ?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
File src/gpu/GrPipelineBuilder.h (right):

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:113: */
// This class can transiently modify its "const" GrPipelineBuilder object but
will restore it when done - so it is notionally "const" correct.
?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:120: 
Should this be const in solidarity ?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:139: private:
// notionally const (as marginalia)
?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:254: */
// This class can transiently modify its "const" GrPipelineBuilder object but
will restore it when done - so it is notionally "const" correct.
?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:280: private:
// notionally const (as marginalia)
?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:414: * owned by the GrPipelineBuilder
// This class can transiently modify its "const" GrPipelineBuilder object but
will restore it when done - so it is notionally "const" correct.
?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:419: 
const here ?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:445: private:
// notionally const (as marginalia)
?

https://codereview.chromium.org/1230023003/diff/60001/src/gpu/GrPipelineBuild...
src/gpu/GrPipelineBuilder.h:446: GrPipelineBuilder* fPipelineBuilder;
line this guy up ?

[joshualitt, 2015-07-13 13:57:28]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-07-13 13:57:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1230023003/#ps80001
(title: "tweaks")

[commit-bot: I haz the power, 2015-07-13 13:57:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230023003/80001

[commit-bot: I haz the power, 2015-07-13 13:58:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 13:58:24]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

(exceeded global retry quota)

[joshualitt, 2015-07-13 14:11:35]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-07-13 14:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1230023003/#ps100001
(title: "deal with warnings")

[commit-bot: I haz the power, 2015-07-13 14:11:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230023003/100001

[commit-bot: I haz the power, 2015-07-13 14:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 14:12:53]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[joshualitt, 2015-07-13 14:15:54]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-07-13 14:16:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1230023003/100001

[commit-bot: I haz the power, 2015-07-13 14:35:08]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/5e6ba21f0722fea6b2f95b9d166d7601ffab18bf