Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12251005: [cc-frame-viewer] Add gl-matrix to third_party [redux] (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
Reviewers:
vmpstr
CC:
chromium-reviews
Visibility:
Public.

Description

[cc-frame-viewer] Add gl-matrix to third_party [redux] Needed by cc-frame-viewer. As noted in README.chromium, this is all unshipped and part of tooling. R=vmpstr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12536 lines, -0 lines) Patch
A tools/cc-frame-viewer/third_party/gl-matrix/.gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/Gemfile View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/Gemfile.lock View 1 chunk +56 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/LICENSE.md View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/README.chromium View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/README.md View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/Rakefile View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/TESTING.md View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/dist/gl-matrix.js View 1 chunk +3865 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/dist/gl-matrix-min.js View 1 chunk +28 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/allclasses.tmpl View 1 chunk +14 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/allfiles.tmpl View 1 chunk +65 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/class.tmpl View 1 chunk +340 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/index.tmpl View 1 chunk +50 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/publish.js View 1 chunk +201 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/static/default.css View 1 chunk +428 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/static/header.html View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/static/index.html View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/jsdoc-template/symbol.tmpl View 1 chunk +35 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/package.json View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/mat2-spec.js View 1 chunk +190 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/mat2d-spec.js View 1 chunk +188 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/mat3-spec.js View 1 chunk +269 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/mat4-spec.js View 1 chunk +566 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/quat-spec.js View 1 chunk +270 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/vec2-spec.js View 1 chunk +506 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/vec3-spec.js View 1 chunk +475 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/gl-matrix/vec4-spec.js View 1 chunk +448 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/helpers/node-helper.js View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/helpers/spec-helper.js View 1 chunk +32 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/spec/jasmine.yml View 1 chunk +73 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix-manifest.js View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix.js.erb View 1 chunk +53 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/common.js View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/mat2.js View 1 chunk +237 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/mat2d.js View 1 chunk +253 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/mat3.js View 1 chunk +429 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/mat4.js View 1 chunk +907 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/quat.js View 1 chunk +457 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/vec2.js View 1 chunk +482 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/vec3.js View 1 chunk +482 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/src/gl-matrix/vec4.js View 1 chunk +486 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/build.rake View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/build/compile.rake View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/build/minify.rake View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/default.rake View 1 chunk +1 line, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/release.rake View 1 chunk +21 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/support/gl-matrix.rb View 1 chunk +84 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/support/gl-matrix/release_helper.rb View 1 chunk +104 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/support/gl-matrix/version.rb View 1 chunk +28 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/test/ci.rake View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/test/coverage.rake View 1 chunk +125 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/test/jasmine.rake View 1 chunk +9 lines, -0 lines 0 comments Download
A tools/cc-frame-viewer/third_party/gl-matrix/tasks/test/node.rake View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nduca
ptal
7 years, 10 months ago (2013-02-12 22:28:55 UTC) #1
vmpstr
lgtm lgtm. Out of curiosity, what's the fix?
7 years, 10 months ago (2013-02-12 22:31:26 UTC) #2
nduca
The maintainer of gl-matrix made a fix upstream and we picked up the change.
7 years, 10 months ago (2013-02-12 23:09:45 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-02-12 23:46:54 UTC) #4
Vangelis Kokkevis
LGTM
7 years, 10 months ago (2013-02-12 23:53:46 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 23:57:00 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698