Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: tools/telemetry/telemetry/internal/backends/browser_backend.py

Issue 1224083015: [telemetry] Add support for requesting memory dumps via DevTools API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/backends/browser_backend.py
diff --git a/tools/telemetry/telemetry/internal/backends/browser_backend.py b/tools/telemetry/telemetry/internal/backends/browser_backend.py
index 4d4070830899861d3583334d26d257d6b63e159c..96ec75b557d3e1a851ee835b48af7c850ef4df9e 100644
--- a/tools/telemetry/telemetry/internal/backends/browser_backend.py
+++ b/tools/telemetry/telemetry/internal/backends/browser_backend.py
@@ -101,3 +101,10 @@ class BrowserBackend(app_backend.AppBackend):
def GetSystemInfo(self):
raise NotImplementedError()
+
+ @property
+ def supports_memory_dumping(self):
+ return False
+
+ def DumpMemory(self, timeout=web_contents.DEFAULT_WEB_CONTENTS_TIMEOUT):
Primiano Tucci (use gerrit) 2015/07/16 10:47:54 Shouldn't you pass also the dumper_config (by defa
petrcermak 2015/07/16 13:35:33 Done.
petrcermak 2015/07/16 19:03:14 I removed the argument after today's discussion.
+ raise NotImplementedError()
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698