tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py - Issue 1224083015: [telemetry] Add support for requesting memory dumps via DevTools API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 1224083015: [telemetry] Add support for requesting memory dumps via DevTools API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/internal/backends/browser_backend.py ('K') | « tools/telemetry/telemetry/internal/backends/browser_backend.py ('k') | tools/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

index 22cbad2a92c4a501622e1c90201c5c7cd62563f6..a7e1cb613208590fbb2b763af98f9ce3ba86c67b 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

@@ -303,3 +303,10 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

self._system_info_backend = system_info_backend.SystemInfoBackend(

self._port)

return self._system_info_backend.GetSystemInfo()

+ @property

+ def supports_memory_dumping(self):

+ return True

+ def DumpMemory(self, timeout=web_contents.DEFAULT_WEB_CONTENTS_TIMEOUT):

+ return self.devtools_client.DumpMemory(timeout)