Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: tools/telemetry/telemetry/internal/backends/browser_backend.py

Issue 1224083015: [telemetry] Add support for requesting memory dumps via DevTools API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.core import platform 5 from telemetry.core import platform
6 from telemetry.core.platform import profiling_controller_backend 6 from telemetry.core.platform import profiling_controller_backend
7 from telemetry import decorators 7 from telemetry import decorators
8 from telemetry.internal.backends import app_backend 8 from telemetry.internal.backends import app_backend
9 from telemetry.internal.browser import web_contents 9 from telemetry.internal.browser import web_contents
10 10
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 return self.IsBrowserRunning() 94 return self.IsBrowserRunning()
95 95
96 def GetStandardOutput(self): 96 def GetStandardOutput(self):
97 raise NotImplementedError() 97 raise NotImplementedError()
98 98
99 def GetStackTrace(self): 99 def GetStackTrace(self):
100 raise NotImplementedError() 100 raise NotImplementedError()
101 101
102 def GetSystemInfo(self): 102 def GetSystemInfo(self):
103 raise NotImplementedError() 103 raise NotImplementedError()
104
105 @property
106 def supports_memory_dumping(self):
107 return False
108
109 def DumpMemory(self, timeout=web_contents.DEFAULT_WEB_CONTENTS_TIMEOUT):
Primiano Tucci (use gerrit) 2015/07/16 10:47:54 Shouldn't you pass also the dumper_config (by defa
petrcermak 2015/07/16 13:35:33 Done.
petrcermak 2015/07/16 19:03:14 I removed the argument after today's discussion.
110 raise NotImplementedError()
OLDNEW
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698