Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223793018: Fake MD Flags sample WebUI (Closed)

Created:
5 years, 5 months ago by michaelpg
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fake MD Flags sample WebUI This: * Registers chrome://md-flags * Creates a WebUI handler for chrome://md-flags * Adds HTML/JS/CSS sources for the handler to serve Marking as "Closed" to get it out of our queues.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix dom-repeat binding #

Patch Set 3 : Fix namespace #

Patch Set 4 : rebase, update to GYP v2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -6 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_flags/compiled_resources2.gyp View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_flags/flag.css View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_flags/flag.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_flags/flag.js View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A + chrome/browser/resources/md_flags/flags_table.css View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A chrome/browser/resources/md_flags/flags_table.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_flags/flags_table.js View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A + chrome/browser/resources/md_flags/md_flags.css View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
A chrome/browser/resources/md_flags/md_flags.html View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_flags/md_flags.js View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/md_flags_ui.h View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/md_flags_ui.cc View 1 2 3 1 chunk +108 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
michaelpg
No need to review, this is just a demonstrative example, but I do have a ...
5 years, 5 months ago (2015-07-07 19:31:51 UTC) #2
Jeremy Klein
https://codereview.chromium.org/1223793018/diff/1/chrome/browser/resources/polymer_flags/flags_table.html File chrome/browser/resources/polymer_flags/flags_table.html (right): https://codereview.chromium.org/1223793018/diff/1/chrome/browser/resources/polymer_flags/flags_table.html#newcode9 chrome/browser/resources/polymer_flags/flags_table.html:9: <template is="dom-repeat" items="[[flags]]"> I wonder if flags needs to ...
5 years, 5 months ago (2015-07-07 21:58:53 UTC) #3
michaelpg
5 years, 5 months ago (2015-07-07 22:20:49 UTC) #4 
https://codereview.chromium.org/1223793018/diff/1/chrome/browser/resources/po...
File chrome/browser/resources/polymer_flags/flags_table.html (right):

https://codereview.chromium.org/1223793018/diff/1/chrome/browser/resources/po...
chrome/browser/resources/polymer_flags/flags_table.html:9: <template
is="dom-repeat" items="[[flags]]">
On 2015/07/07 21:58:53, Jeremy Klein wrote:
> I wonder if flags needs to be 2-way bound here... Did you try that already?

You're right, that did it. Thanks!

I wasn't aware two-way binding had any effect on templates. Now I feel tempted
to dive into the Templatizer code and see what's going on...

Powered by Google App Engine
This is Rietveld 408576698