chrome/browser/resources/polymer_flags/flags_table.html - Issue 1223793018: Fake MD Flags sample WebUI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/polymer_flags/flags_table.html

Issue 1223793018: Fake MD Flags sample WebUI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">

	3 <link rel="import" href="flag.html">

	4

	5 <dom-module id="cr-flags-table">

	6 <link rel="import" type="css" href="flags_table.css">

	7 <template>

	8 <div class="layout vertical">

	9 <template is="dom-repeat" items="[[flags]]">
	Jeremy Klein 2015/07/07 21:58:53 I wonder if flags needs to be 2-way bound here... I wonder if flags needs to be 2-way bound here... Did you try that already? michaelpg 2015/07/07 22:20:49 You're right, that did it. Thanks! I wasn't aware Show quoted text On 2015/07/07 21:58:53, Jeremy Klein wrote: > I wonder if flags needs to be 2-way bound here... Did you try that already? You're right, that did it. Thanks! I wasn't aware two-way binding had any effect on templates. Now I feel tempted to dive into the Templatizer code and see what's going on...
	10 <cr-flag flag-id="[[item.id]]" displayName="[[item.name]]"

	11 description="[[item.description]]" enabled="{{item.enabled}}">

	12 </cr-flag>

	13 </template>

	14 </template>

	15 <script src="chrome://polymer-flags/flags_table.js"></script>

	16 </dom-module>

OLD	NEW