Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 1223673002: Revert of Implement support for CHROMIUM_path_rendering pseudo extension (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@chromium-pathrendering-prepare-03
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Implement support for CHROMIUM_path_rendering pseudo extension (patchset #4 id:60001 of https://codereview.chromium.org/1192663002/) Reason for revert: DEPS roll failing Original issue's description: > Implement support for CHROMIUM_path_rendering pseudo extension > > Implement support for path rendering in Chromium through > CHROMIUM_path_rendering pseudo extension. > > The extension defines a new pseudo-gl function, > BindFragmentInputLocation. This behaves similarly to the > BindUniformLocation pseudo-gl function. The idea is to assign fragment > input location to a fragment input before linking the program. > > BUG=chromium:344330 > > Committed: https://skia.googlesource.com/skia/+/eeef46d181f9f8db388ecea81df699fc1b3c9280 TBR=bsalomon@google.com,joshualitt@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:344330 Committed: https://skia.googlesource.com/skia/+/2853fe409efb2da9245d31a65a63ae3d8753931f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -51 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 3 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLPathProgramBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLPathProgramBuilder.cpp View 1 chunk +1 line, -17 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Revert of Implement support for CHROMIUM_path_rendering pseudo extension
5 years, 5 months ago (2015-07-02 19:53:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223673002/1
5 years, 5 months ago (2015-07-02 19:53:18 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 19:53:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2853fe409efb2da9245d31a65a63ae3d8753931f

Powered by Google App Engine
This is Rietveld 408576698