Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1223403004: cc: Disable Renderer latency recovery with --disable-gpu-vsync (Closed)

Created:
5 years, 5 months ago by brianderson
Modified:
5 years, 5 months ago
Reviewers:
sunnyps, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rendererLatencyRecoveryHeuristic13
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Disable Renderer latency recovery with --disable-gpu-vsync The recovery heuristic doesn't work with --disable-gpu-vsync since it ends up skipping every BeginFrame we get (a lot) before the swap ack arrives. BUG=406158 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/16a5cb2e4754ac98dc2d84730ea0bc17396d3022 Cr-Commit-Position: refs/heads/master@{#338412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/scheduler/scheduler.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
brianderson
5 years, 5 months ago (2015-07-10 22:45:38 UTC) #2
sunnyps
LGTM
5 years, 5 months ago (2015-07-10 23:04:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223403004/1
5 years, 5 months ago (2015-07-10 23:37:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-11 00:39:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16a5cb2e4754ac98dc2d84730ea0bc17396d3022 Cr-Commit-Position: refs/heads/master@{#338412}
5 years, 5 months ago (2015-07-11 00:40:44 UTC) #7
mithro-old
5 years, 5 months ago (2015-07-13 01:16:38 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698