Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: base/trace_event/trace_event_impl.h

Issue 1223393002: Add some missing virtual destructors to base classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update V8SamplingProfiler Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager.h ('k') | base/trace_event/trace_event_memory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_impl.h
diff --git a/base/trace_event/trace_event_impl.h b/base/trace_event/trace_event_impl.h
index ccb850033e1926d59ff4396b8a9bb36acf61a109..108ae8be328b075243d5aeef9b15f49f14b05931 100644
--- a/base/trace_event/trace_event_impl.h
+++ b/base/trace_event/trace_event_impl.h
@@ -367,6 +367,8 @@ class BASE_EXPORT TraceLog : public MemoryDumpProvider {
// on-demand.
class BASE_EXPORT EnabledStateObserver {
public:
+ virtual ~EnabledStateObserver() = default;
+
// Called just after the tracing system becomes enabled, outside of the
// |lock_|. TraceLog::IsEnabled() is true at this point.
virtual void OnTraceLogEnabled() = 0;
« no previous file with comments | « base/trace_event/memory_dump_manager.h ('k') | base/trace_event/trace_event_memory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698