Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223193009: WIP attempt to replace StartWorker/StopWorker IPCs with a new mojo EmbeddedWorker service.

Created:
5 years, 5 months ago by Marijn Kruisselbrink
Modified:
5 years, 5 months ago
Reviewers:
CC:
chromium-reviews, maxbogue+watch_chromium.org, qsr+mojo_chromium.org, zea+watch_chromium.org, tzik, yzshen+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, tim+watch_chromium.org, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, plaree+watch_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, maniscalco+watch_chromium.org, michaeln, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-event-dispatching-option2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP attempt to replace StartWorker/StopWorker IPCs with a new mojo EmbeddedWorker service. Causes havoc in unit tests... BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+759 lines, -657 lines) Patch
M content/browser/background_sync/background_sync_manager_unittest.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M content/browser/geofencing/geofencing_manager_unittest.cc View 4 chunks +10 lines, -14 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 9 chunks +50 lines, -27 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 2 chunks +2 lines, -7 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 5 chunks +12 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 4 chunks +85 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 14 chunks +72 lines, -131 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 9 chunks +48 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 34 chunks +94 lines, -85 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.h View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 19 chunks +28 lines, -34 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 21 chunks +95 lines, -49 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/service_worker/embedded_worker.mojom View 1 chunk +20 lines, -0 lines 0 comments Download
M content/common/service_worker/embedded_worker_messages.h View 2 chunks +0 lines, -19 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 5 chunks +4 lines, -9 lines 0 comments Download
D content/renderer/service_worker/embedded_worker_dispatcher.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/renderer/service_worker/embedded_worker_dispatcher.cc View 1 chunk +0 lines, -111 lines 0 comments Download
A content/renderer/service_worker/embedded_worker_impl.h View 1 chunk +49 lines, -0 lines 0 comments Download
A content/renderer/service_worker/embedded_worker_impl.cc View 1 chunk +120 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 6 chunks +7 lines, -23 lines 0 comments Download

Depends on Patchset:

Issue 1221503003 Patch 60001

Powered by Google App Engine
This is Rietveld 408576698