content/browser/service_worker/embedded_worker_registry.h - Issue 1223193009: WIP attempt to replace StartWorker/StopWorker IPCs with a new mojo EmbeddedWorker service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_registry.h

Issue 1223193009: WIP attempt to replace StartWorker/StopWorker IPCs with a new mojo EmbeddedWorker service. Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-event-dispatching-option2

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance_unittest.cc ('k') | content/browser/service_worker/embedded_worker_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_registry.h

diff --git a/content/browser/service_worker/embedded_worker_registry.h b/content/browser/service_worker/embedded_worker_registry.h

index 575fd99db2a601d0fcaa79d353b5de5ac3fc5516..a8433cccdf0b513b5a56cddfa2ecf919d978f197 100644

--- a/content/browser/service_worker/embedded_worker_registry.h

+++ b/content/browser/service_worker/embedded_worker_registry.h

@@ -17,7 +17,6 @@

#include "content/common/content_export.h"

#include "content/common/service_worker/service_worker_status_code.h"

-struct EmbeddedWorkerMsg_StartWorker_Params;

class GURL;

namespace IPC {

@@ -56,12 +55,8 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry

// This doesn't actually start or stop the worker.

scoped_ptr<EmbeddedWorkerInstance> CreateWorker();

- // Called from EmbeddedWorkerInstance, relayed to the child process.

- ServiceWorkerStatusCode SendStartWorker(

- scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,

- int process_id);

- ServiceWorkerStatusCode StopWorker(int process_id,

- int embedded_worker_id);

+ // Called from EmbeddedWorkerInstance to record starting a worker.

+ void WorkerStarting(int embedded_worker_id, int process_id);

// Stop all active workers, even if they're handling events.

void Shutdown();