content/browser/service_worker/embedded_worker_instance_unittest.cc - Issue 1223193009: WIP attempt to replace StartWorker/StopWorker IPCs with a new mojo EmbeddedWorker service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance_unittest.cc

Issue 1223193009: WIP attempt to replace StartWorker/StopWorker IPCs with a new mojo EmbeddedWorker service. Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-event-dispatching-option2

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/browser/service_worker/embedded_worker_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance_unittest.cc

diff --git a/content/browser/service_worker/embedded_worker_instance_unittest.cc b/content/browser/service_worker/embedded_worker_instance_unittest.cc

index 451be9c94e9f9e836c516c7624067e1fd441fcec..d210b50feb8e4ed5b65003a30995bfd118788dd0 100644

--- a/content/browser/service_worker/embedded_worker_instance_unittest.cc

+++ b/content/browser/service_worker/embedded_worker_instance_unittest.cc

@@ -108,10 +108,10 @@ TEST_F(EmbeddedWorkerInstanceTest, StartAndStop) {

EXPECT_EQ(EmbeddedWorkerInstance::STOPPED, worker->status());

// Verify that we've sent two messages to start and terminate the worker.

- ASSERT_TRUE(ipc_sink()->GetUniqueMessageMatching(

- EmbeddedWorkerMsg_StartWorker::ID));

- ASSERT_TRUE(ipc_sink()->GetUniqueMessageMatching(

- EmbeddedWorkerMsg_StopWorker::ID));

+ // ASSERT_TRUE(ipc_sink()->GetUniqueMessageMatching(

+ // EmbeddedWorkerMsg_StartWorker::ID));

+ // ASSERT_TRUE(ipc_sink()->GetUniqueMessageMatching(

+ // EmbeddedWorkerMsg_StopWorker::ID));

}

TEST_F(EmbeddedWorkerInstanceTest, StopWhenDevToolsAttached) {