Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1223173006: Get rid of clampScrollOffset and make maximumScrollPosition sane. (Closed)

Created:
5 years, 5 months ago by szager1
Modified:
5 years, 2 months ago
Reviewers:
skobes
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of clampScrollOffset and make maximumScrollPosition sane. This also gets rid of a bug in clampScrollOffset that sometimes caused it to use a maximum offset that was one pixel too small, so a few tests need to be rebaselined. BUG=492871 R=skobes@chromium.org Committed: https://crrev.com/c5b90a1590f9d7d96eec5f85a9dc018ddf5fb295 git-svn-id: svn://svn.chromium.org/blink/trunk@201983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Use scrollToOffset everywhere. #

Patch Set 3 : Add scrollToPosition #

Patch Set 4 : in progress #

Patch Set 5 : rebase #

Patch Set 6 : Get rid of old scrollWidth kludge #

Patch Set 7 : Revert changes to Element::clientWidth, etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -49 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 4 5 1 chunk +4 lines, -11 lines 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 3 4 5 2 chunks +2 lines, -8 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 1 2 3 4 5 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 2 3 4 5 5 chunks +22 lines, -25 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
szager1
5 years, 5 months ago (2015-07-09 19:11:54 UTC) #3
skobes
lgtm
5 years, 5 months ago (2015-07-09 19:15:07 UTC) #4
szager1
Slight tweak, PTAL: toScrollOffset is used everywhere in DPLScrollableArea, rather than mixing with setScrollPosition.
5 years, 5 months ago (2015-07-09 19:24:12 UTC) #5
skobes
still lgtm
5 years, 5 months ago (2015-07-09 19:25:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223173006/40001
5 years, 5 months ago (2015-07-10 23:26:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/62545)
5 years, 5 months ago (2015-07-11 00:42:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223173006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1223173006/120001
5 years, 3 months ago (2015-09-09 15:58:45 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201983
5 years, 3 months ago (2015-09-09 16:04:23 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:00:21 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c5b90a1590f9d7d96eec5f85a9dc018ddf5fb295

Powered by Google App Engine
This is Rietveld 408576698