Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1223173006: Get rid of clampScrollOffset and make maximumScrollPosition sane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revert changes to Element::clientWidth, etc. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 m_tickmarks = tickmarks; 329 m_tickmarks = tickmarks;
330 invalidatePaintForTickmarks(); 330 invalidatePaintForTickmarks();
331 } 331 }
332 332
333 void invalidatePaintForTickmarks() const; 333 void invalidatePaintForTickmarks() const;
334 334
335 // Since the compositor can resize the viewport due to top controls and 335 // Since the compositor can resize the viewport due to top controls and
336 // commit scroll offsets before a WebView::resize occurs, we need to adjust 336 // commit scroll offsets before a WebView::resize occurs, we need to adjust
337 // our scroll extents to prevent clamping the scroll offsets. 337 // our scroll extents to prevent clamping the scroll offsets.
338 void setTopControlsViewportAdjustment(float); 338 void setTopControlsViewportAdjustment(float);
339 IntSize topControlsSize() const { return IntSize(0, roundf(m_topControlsView portAdjustment)); }
339 340
340 IntPoint maximumScrollPosition() const override; 341 IntPoint maximumScrollPosition() const override;
341 342
342 // ScrollableArea interface 343 // ScrollableArea interface
343 void invalidateScrollbarRect(Scrollbar*, const IntRect&) override; 344 void invalidateScrollbarRect(Scrollbar*, const IntRect&) override;
344 void getTickmarks(Vector<IntRect>&) const override; 345 void getTickmarks(Vector<IntRect>&) const override;
345 void scrollTo(const DoublePoint&); 346 void scrollTo(const DoublePoint&);
346 IntRect scrollableAreaBoundingBox() const override; 347 IntRect scrollableAreaBoundingBox() const override;
347 bool scrollAnimatorEnabled() const override; 348 bool scrollAnimatorEnabled() const override;
348 bool usesCompositedScrolling() const override; 349 bool usesCompositedScrolling() const override;
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 static const unsigned visualPixelThreshold = 32 * 32; 858 static const unsigned visualPixelThreshold = 32 * 32;
858 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 859 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
859 setIsVisuallyNonEmpty(); 860 setIsVisuallyNonEmpty();
860 } 861 }
861 862
862 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 863 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
863 864
864 } // namespace blink 865 } // namespace blink
865 866
866 #endif // FrameView_h 867 #endif // FrameView_h
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698