Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayerScrollableArea.h

Issue 1223173006: Get rid of clampScrollOffset and make maximumScrollPosition sane. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revert changes to Element::clientWidth, etc. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 ScrollBehavior scrollBehaviorStyle() const override; 125 ScrollBehavior scrollBehaviorStyle() const override;
126 126
127 double scrollXOffset() const { return m_scrollOffset.width() + scrollOrigin( ).x(); } 127 double scrollXOffset() const { return m_scrollOffset.width() + scrollOrigin( ).x(); }
128 double scrollYOffset() const { return m_scrollOffset.height() + scrollOrigin ().y(); } 128 double scrollYOffset() const { return m_scrollOffset.height() + scrollOrigin ().y(); }
129 129
130 DoubleSize scrollOffset() const { return m_scrollOffset; } 130 DoubleSize scrollOffset() const { return m_scrollOffset; }
131 131
132 // FIXME: We shouldn't allow access to m_overflowRect outside this class. 132 // FIXME: We shouldn't allow access to m_overflowRect outside this class.
133 LayoutRect overflowRect() const { return m_overflowRect; } 133 LayoutRect overflowRect() const { return m_overflowRect; }
134 134
135 void scrollToOffset(const DoubleSize& scrollOffset, ScrollOffsetClamping = S crollOffsetUnclamped, ScrollBehavior = ScrollBehaviorInstant); 135 void scrollToPosition(const DoublePoint& scrollPosition, ScrollOffsetClampin g = ScrollOffsetUnclamped, ScrollBehavior = ScrollBehaviorInstant);
136
137 void scrollToOffset(const DoubleSize& scrollOffset, ScrollOffsetClamping cla mp = ScrollOffsetUnclamped, ScrollBehavior scrollBehavior = ScrollBehaviorInstan t)
138 {
139 scrollToPosition(-scrollOrigin() + scrollOffset, clamp, scrollBehavior);
140 }
136 141
137 void scrollToXOffset(double x, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant) 142 void scrollToXOffset(double x, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant)
138 { 143 {
139 scrollToOffset(DoubleSize(x, scrollYOffset()), clamp, scrollBehavior); 144 scrollToOffset(DoubleSize(x, scrollYOffset()), clamp, scrollBehavior);
140 } 145 }
141 146
142 void scrollToYOffset(double y, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant) 147 void scrollToYOffset(double y, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant)
143 { 148 {
144 scrollToOffset(DoubleSize(scrollXOffset(), y), clamp, scrollBehavior); 149 scrollToOffset(DoubleSize(scrollXOffset(), y), clamp, scrollBehavior);
145 } 150 }
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 bool hasHorizontalOverflow() const; 241 bool hasHorizontalOverflow() const;
237 bool hasVerticalOverflow() const; 242 bool hasVerticalOverflow() const;
238 bool hasScrollableHorizontalOverflow() const; 243 bool hasScrollableHorizontalOverflow() const;
239 bool hasScrollableVerticalOverflow() const; 244 bool hasScrollableVerticalOverflow() const;
240 bool visualViewportSuppliesScrollbars() const; 245 bool visualViewportSuppliesScrollbars() const;
241 246
242 bool needsScrollbarReconstruction() const; 247 bool needsScrollbarReconstruction() const;
243 248
244 void computeScrollDimensions(); 249 void computeScrollDimensions();
245 250
246 // TODO(bokan): This method hides the base class version and is subtly diffe rent.
247 // Should be unified.
248 DoubleSize clampScrollOffset(const DoubleSize&) const;
249
250 void setScrollOffset(const IntPoint&, ScrollType) override; 251 void setScrollOffset(const IntPoint&, ScrollType) override;
251 void setScrollOffset(const DoublePoint&, ScrollType) override; 252 void setScrollOffset(const DoublePoint&, ScrollType) override;
252 253
253 LayoutUnit verticalScrollbarStart(int minX, int maxX) const; 254 LayoutUnit verticalScrollbarStart(int minX, int maxX) const;
254 LayoutUnit horizontalScrollbarStart(int minX) const; 255 LayoutUnit horizontalScrollbarStart(int minX) const;
255 IntSize scrollbarOffset(const Scrollbar*) const; 256 IntSize scrollbarOffset(const Scrollbar*) const;
256 257
257 PassRefPtrWillBeRawPtr<Scrollbar> createScrollbar(ScrollbarOrientation); 258 PassRefPtrWillBeRawPtr<Scrollbar> createScrollbar(ScrollbarOrientation);
258 void destroyScrollbar(ScrollbarOrientation); 259 void destroyScrollbar(ScrollbarOrientation);
259 260
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 LayoutScrollbarPart* m_resizer; 306 LayoutScrollbarPart* m_resizer;
306 307
307 #if ENABLE(ASSERT) 308 #if ENABLE(ASSERT)
308 bool m_hasBeenDisposed; 309 bool m_hasBeenDisposed;
309 #endif 310 #endif
310 }; 311 };
311 312
312 } // namespace blink 313 } // namespace blink
313 314
314 #endif // LayerScrollableArea_h 315 #endif // LayerScrollableArea_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTextControlSingleLine.cpp ('k') | Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698