extensions/renderer/print_native_handler.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/print_native_handler.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/print_native_handler.cc

diff --git a/extensions/renderer/print_native_handler.cc b/extensions/renderer/print_native_handler.cc

index 8e71eb5f7b5ccba832b1db96d4240765d5a19772..b6ee63a7e59c2e29014efecda27d8cde6f11cd98 100644

--- a/extensions/renderer/print_native_handler.cc

+++ b/extensions/renderer/print_native_handler.cc

@@ -26,7 +26,7 @@ void PrintNativeHandler::Print(

for (int i = 0; i < args.Length(); ++i)

components.push_back(*v8::String::Utf8Value(args[i]));

- LOG(ERROR) << JoinString(components, ',');

+ LOG(ERROR) << base::JoinString(components, ",");

}

} // namespace extensions

« no previous file with comments | « extensions/common/url_pattern.cc ('k') | gin/modules/console.cc » ('j') | no next file with comments »