extensions/common/url_pattern.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/url_pattern.cc

diff --git a/extensions/common/url_pattern.cc b/extensions/common/url_pattern.cc

index b72ce3034120e8c2f03dd537235e5f4e5d95bb6c..502c459d43353ac94c3443d9a7d6d724e53074ea 100644

--- a/extensions/common/url_pattern.cc

+++ b/extensions/common/url_pattern.cc

@@ -249,7 +249,7 @@ URLPattern::ParseResult URLPattern::Parse(const std::string& pattern) {

host_components.erase(host_components.begin(),

host_components.begin() + 1);

}

- host_ = JoinString(host_components, '.');

+ host_ = base::JoinString(host_components, ".");

path_start_pos = host_end_pos;

}