gin/modules/console.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/console.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/console.cc

diff --git a/gin/modules/console.cc b/gin/modules/console.cc

index 75241df081a7acd1f95fc8e2a87165890f4966e3..231d8fc47610ecabfa1345695a63c1f0c95c848f 100644

--- a/gin/modules/console.cc

+++ b/gin/modules/console.cc

@@ -25,7 +25,7 @@ void Log(Arguments* args) {

args->ThrowError();

return;

}

- std::cout << JoinString(messages, ' ') << std::endl;

+ std::cout << base::JoinString(messages, " ") << std::endl;

}

WrapperInfo g_wrapper_info = { kEmbedderNativeGin };

« no previous file with comments | « extensions/renderer/print_native_handler.cc ('k') | google_apis/gaia/fake_gaia.cc » ('j') | no next file with comments »