Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: extensions/browser/updater/extension_downloader.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/content_verifier.cc ('k') | extensions/browser/updater/manifest_fetch_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/updater/extension_downloader.cc
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
index a038ebba58217419f99e5e79b5f56bd4a94de376..d1d6468b0c94dc866e49583767e2f0c9b1711bb4 100644
--- a/extensions/browser/updater/extension_downloader.cc
+++ b/extensions/browser/updater/extension_downloader.cc
@@ -136,7 +136,7 @@ bool IncrementAuthUserIndex(GURL* url) {
return false;
new_query_parts.push_back(
base::StringPrintf("%s=%d", kAuthUserQueryKey, user_index + 1));
- std::string new_query_string = JoinString(new_query_parts, '&');
+ std::string new_query_string = base::JoinString(new_query_parts, "&");
url::Component new_query(0, new_query_string.size());
url::Replacements<char> replacements;
replacements.SetQuery(new_query_string.c_str(), new_query);
@@ -469,7 +469,7 @@ void ExtensionDownloader::CreateManifestFetcher() {
std::vector<std::string> id_vector(
manifests_queue_.active_request()->extension_ids().begin(),
manifests_queue_.active_request()->extension_ids().end());
- std::string id_list = JoinString(id_vector, ',');
+ std::string id_list = base::JoinString(id_vector, ",");
VLOG(2) << "Fetching " << manifests_queue_.active_request()->full_url()
<< " for " << id_list;
}
« no previous file with comments | « extensions/browser/content_verifier.cc ('k') | extensions/browser/updater/manifest_fetch_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698