extensions/browser/content_verifier.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/content_verifier.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/content_verifier.cc

diff --git a/extensions/browser/content_verifier.cc b/extensions/browser/content_verifier.cc

index 3bbe4a9a6bdc2d67c697e17625b7fb29d87fe500..b85e8eeebcac6f77b6bac1d0b7f300b2568cfd45 100644

--- a/extensions/browser/content_verifier.cc

+++ b/extensions/browser/content_verifier.cc

@@ -124,7 +124,8 @@ static base::FilePath MakeImagePathRelative(const base::FilePath& path) {

// Note that elsewhere we always normalize path separators to '/' so this

// should work for all platforms.

- return base::FilePath(JoinString(parts, '/'));

+ return base::FilePath(

+ base::JoinString(parts, base::FilePath::StringType(1, '/')));

}

void ContentVerifier::OnExtensionLoaded(