extensions/browser/updater/manifest_fetch_data.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/updater/manifest_fetch_data.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/updater/manifest_fetch_data.cc

diff --git a/extensions/browser/updater/manifest_fetch_data.cc b/extensions/browser/updater/manifest_fetch_data.cc

index 6511a1eb6a8d0537f752d1f24065059536cf9ba2..f72f32efcbc94f5220166c2469d421757e418474 100644

--- a/extensions/browser/updater/manifest_fetch_data.cc

+++ b/extensions/browser/updater/manifest_fetch_data.cc

@@ -143,7 +143,8 @@ bool ManifestFetchData::AddExtension(const std::string& id,

}

std::string extra = full_url_.has_query() ? "&" : "?";

- extra += "x=" + net::EscapeQueryParamValue(JoinString(parts, '&'), true);

+ extra +=

+ "x=" + net::EscapeQueryParamValue(base::JoinString(parts, "&"), true);

// Check against our max url size, exempting the first extension added.

int new_size = full_url_.possibly_invalid_spec().size() + extra.size();