chrome/browser/extensions/extension_service_unittest.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index 0a4c7fa0d49631f886faaef9710f702817bf5ca1..3378d72db7de623b815975fe239e77b04c9079f1 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -1806,8 +1806,9 @@ TEST_F(ExtensionServiceTest, InstallUserScript) {

EXPECT_TRUE(installed_) << "Nothing was installed.";

EXPECT_FALSE(was_update_) << path.value();

ASSERT_EQ(1u, loaded_.size()) << "Nothing was loaded.";

- EXPECT_EQ(0u, errors.size()) << "There were errors: "

- << JoinString(errors, ',');

+ EXPECT_EQ(0u, errors.size())

+ << "There were errors: "

+ << base::JoinString(errors, base::ASCIIToUTF16(","));

EXPECT_TRUE(service()->GetExtensionById(loaded_[0]->id(), false))

<< path.value();