chrome/browser/extensions/extension_startup_browsertest.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_startup_browsertest.cc

diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc

index bf8faf4539048a6a599bdf189d69b65d9a146055..ad5f1abafb580f96e2fdcebd77ac9703804ef750 100644

--- a/chrome/browser/extensions/extension_startup_browsertest.cc

+++ b/chrome/browser/extensions/extension_startup_browsertest.cc

@@ -67,7 +67,9 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {

unauthenticated_load_allowed_ = false;

#endif

} else {

- base::FilePath::StringType paths = JoinString(load_extensions_, ',');

+ base::FilePath::StringType paths =

+ base::JoinString(load_extensions_,

+ base::FilePath::StringType(1, ','));

command_line->AppendSwitchNative(switches::kLoadExtension,

paths);

command_line->AppendSwitch(switches::kDisableExtensionsFileAccessCheck);