chrome/browser/extensions/extension_message_bubble_controller.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_message_bubble_controller.cc

diff --git a/chrome/browser/extensions/extension_message_bubble_controller.cc b/chrome/browser/extensions/extension_message_bubble_controller.cc

index ac198fd9ea7e15e2bdcb18dcd97a5852c322e70f..0bc28021af01ef3c47f9a4d8e5fc778db96ed794 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller.cc

+++ b/chrome/browser/extensions/extension_message_bubble_controller.cc

@@ -141,7 +141,7 @@ base::string16 ExtensionMessageBubbleController::GetExtensionListForDisplay() {

base::string16 prefix = bullet_point + base::ASCIIToUTF16(" ");

for (base::string16& str : extension_list)

str.insert(0, prefix);

- return JoinString(extension_list, base::ASCIIToUTF16("\n"));

+ return base::JoinString(extension_list, base::ASCIIToUTF16("\n"));

}

const ExtensionIdList& ExtensionMessageBubbleController::GetExtensionIdList() {