Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 12226086: Alternate NTP: Fix dev tools layout (Closed)

Created:
7 years, 10 months ago by sail
Modified:
7 years, 10 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Alternate NTP: Fix dev tools layout When docked to the right the dev tool's web view would be cropped. This bug was due to the way I implemented view layout in r181301. The dev tool view was being correctly layed out but the subview was not. To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead. BUG=173205 TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -23 lines) Patch
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 2 chunks +11 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sail
dhollowa: Sorry for the code churn here. The new code should be simpler though.
7 years, 10 months ago (2013-02-11 01:59:33 UTC) #1
dhollowa
lgtm
7 years, 10 months ago (2013-02-11 17:43:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12226086/1
7 years, 10 months ago (2013-02-11 17:51:22 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-11 18:16:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12226086/1
7 years, 10 months ago (2013-02-11 21:46:51 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 01:29:07 UTC) #6
Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698