Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3852)

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

Issue 12226086: Alternate NTP: Fix dev tools layout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
index f5373fe29faddec3693ff41f3ec015f14b77528a..98700834c3196ec58d53297fc7401a1387934627 100644
--- a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
@@ -8,6 +8,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/cocoa/browser_window_controller.h"
+#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
class DevToolsControllerTest : public InProcessBrowserTest {
@@ -85,3 +86,25 @@ IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, ViewSize) {
SetDockSide(DEVTOOLS_DOCK_SIDE_RIGHT);
EXPECT_EQ(height - offset, NSHeight([dev_tools_view bounds]));
}
+
+// Verify that the dev tool's web view is layed out correctly when docked to the
+// right.
+IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, WebViewLayout) {
+ CGFloat offset = 50;
+ [controller() setTopContentOffset:offset];
+
+ SetDockSide(DEVTOOLS_DOCK_SIDE_RIGHT);
+ AddTabAtIndex(0,
+ GURL(chrome::kAboutBlankURL),
+ content::PAGE_TRANSITION_TYPED);
+ DevToolsWindow::ToggleDevToolsWindow(browser(), DEVTOOLS_TOGGLE_ACTION_SHOW);
+
+ NSView* container_view = [[[controller() splitView] subviews] lastObject];
+ NSView* dev_tools_view = [[container_view subviews] lastObject];
+ NSView* web_view = [[dev_tools_view subviews] lastObject];
+
+ CGFloat height = NSHeight([[controller() splitView] bounds]);
+
+ EXPECT_EQ(height - offset, NSHeight([web_view bounds]));
+ EXPECT_EQ(0, NSMinY([web_view bounds]));
+}
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698