|
|
Created:
5 years, 5 months ago by Dirk Pranke Modified:
5 years, 4 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionMake 'git cl status' report the current branch even if there's no active CL.
R=ianh@google.com
TBR=iannucci@chromium.org
Patch Set 1 #Messages
Total messages: 20 (7 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222383008/1
dpranke@chromium.org changed reviewers: + ianh@google.com, iannucci@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222383008/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/07/08 15:43:30, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Since this is actually Ian's patch from https://codereview.chromium.org/1142283002/ (that I reviewed), I'll TBR iannucci.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222383008/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)
On 2015/07/08 15:51:13, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...) Looks like these failures are legit, probably due to the change in logging in these situations.
I'm happy to fix the expectation files if you can point me in the right direction. On Wed, Jul 8, 2015 at 8:57 AM, <dpranke@chromium.org> wrote: > On 2015/07/08 15:51:13, commit-bot: I haz the power wrote: > >> Try jobs failed on following builders: >> depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, >> > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre... > ) > > Looks like these failures are legit, probably due to the change in logging > in > these situations. > > https://codereview.chromium.org/1222383008/ > -- Ian Hickson To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2015/07/08 16:27:19, chromium-reviews wrote: > I'm happy to fix the expectation files if you can point me in the right > direction. I'm not actually familiar w/ the tests that are failing, but I'd look at depot_tools/tests/{basic.sh,push-basic.sh} and start poking around. 'git cl presubmit' when run locally should produce the same failures, as should running './push-basic.sh' from inside the tests dir.
I fixed the tests and landed the patch in https://codereview.chromium.org/1263253002/ . Closing this CL; hopefully that's okay.
Message was sent while issue was closed.
Sorry, I was on vacation. Thanks for taking care of this! On Fri, Jul 31, 2015 at 11:48 AM, <dpranke@chromium.org> wrote: > I fixed the tests and landed the patch in > https://codereview.chromium.org/1263253002/ . > > Closing this CL; hopefully that's okay. > > https://codereview.chromium.org/1222383008/ > -- Ian Hickson To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |