Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1222383008: Make 'git cl status' report the current branch even if there's no active CL. (Closed)

Created:
5 years, 5 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
iannucci, Hixie
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make 'git cl status' report the current branch even if there's no active CL. R=ianh@google.com TBR=iannucci@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M git_cl.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222383008/1
5 years, 5 months ago (2015-07-08 15:24:07 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/114)
5 years, 5 months ago (2015-07-08 15:28:55 UTC) #5
Hixie
lgtm
5 years, 5 months ago (2015-07-08 15:31:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222383008/1
5 years, 5 months ago (2015-07-08 15:43:27 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-08 15:43:30 UTC) #10
Dirk Pranke
On 2015/07/08 15:43:30, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 5 months ago (2015-07-08 15:45:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222383008/1
5 years, 5 months ago (2015-07-08 15:46:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/116)
5 years, 5 months ago (2015-07-08 15:51:13 UTC) #15
Dirk Pranke
On 2015/07/08 15:51:13, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-07-08 15:57:06 UTC) #16
chromium-reviews
I'm happy to fix the expectation files if you can point me in the right ...
5 years, 5 months ago (2015-07-08 16:27:19 UTC) #17
Dirk Pranke
On 2015/07/08 16:27:19, chromium-reviews wrote: > I'm happy to fix the expectation files if you ...
5 years, 5 months ago (2015-07-08 19:29:00 UTC) #18
Dirk Pranke
I fixed the tests and landed the patch in https://codereview.chromium.org/1263253002/ . Closing this CL; hopefully ...
5 years, 4 months ago (2015-07-31 18:48:58 UTC) #19
chromium-reviews
5 years, 4 months ago (2015-08-17 15:26:36 UTC) #20
Message was sent while issue was closed.
Sorry, I was on vacation. Thanks for taking care of this!

On Fri, Jul 31, 2015 at 11:48 AM, <dpranke@chromium.org> wrote:

> I fixed the tests and landed the patch in
> https://codereview.chromium.org/1263253002/ .
>
> Closing this CL; hopefully that's okay.
>
> https://codereview.chromium.org/1222383008/
>



-- 
Ian Hickson

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698