Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1142283002:
Make 'git cl status' report the current branch even if there's no active CL. (Closed)
|
Created:
5 years, 7 months ago by Hixie Modified:
4 years, 4 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionMake 'git cl status' report the current branch even if there's no active CL.
R=iannucci@chromium.org
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 19 (8 generated)
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by ianh@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because it did not recognize the base URL. Please commit your change manually.
Looks like I don't have the rights to commit to this repo, and the CQ doesn't know about. Any chance one of you can check this in? Thanks! On Tue, Jul 7, 2015 at 8:58 AM, <commit-bot@chromium.org> wrote: > Commit queue rejected this change because it did not recognize the base > URL. > Please commit your change manually. > > https://codereview.chromium.org/1142283002/ > -- Ian Hickson To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by dpranke@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because it did not recognize the base URL. Please commit your change manually.
On 2015/07/07 18:48:03, commit-bot: I haz the power wrote: > Commit queue rejected this change because it did not recognize the base URL. > Please commit your change manually. Hm, CQ should work here. Sheng is taking a look.
On 2015/07/07 19:42:35, iannucci wrote:
> On 2015/07/07 18:48:03, commit-bot: I haz the power wrote:
> > Commit queue rejected this change because it did not recognize the base URL.
> > Please commit your change manually.
>
> Hm, CQ should work here. Sheng is taking a look.
Can you rebase this on the latest depot_tools and re-upload? It looks like
depot_tools has a new CQ project now ("depot_tools") instead of the old "tools"
project.
The CQ bit was checked by ianh@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1142283002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
I tried, and it got further than last time, but still no success? Not sure what to do next. On Tue, Jul 7, 2015 at 6:08 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Try jobs failed on following builders: > depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, no build > URL) > > https://codereview.chromium.org/1142283002/ > -- Ian Hickson To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2015/07/08 15:11:44, chromium-reviews wrote: > I tried, and it got further than last time, but still no success? Not sure > what to do next. depot_tools is still an SVN repo; you'd need to run 'git auto-svn' and then re-upload. If you're on Yosemite, git-svn is borked, so you'd need to follow the instructions on http://www.contrid.co.za/2014/10/solved-os-x-yosemite-git-svn-broken/ as well. Or you can approve https://codereview.chromium.org/1222383008/ where I just did this for you (to test things ;). |
