Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1222143003: Removes temporary guard against DISALLOW_IMPLICIT_CONSTRUCTORS in Blink. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
Reviewers:
Erik Corry, Nico
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@no-redefine
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removes temporary guard against DISALLOW_IMPLICIT_CONSTRUCTORS in Blink. This is part of a three-sided CL: 1: https://codereview.chromium.org/1211403004 2: https://codereview.chromium.org/1212403003 3: <this> BUG=447156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/wtf/dtoa/utils.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-02 13:41:35 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-02 15:00:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222143003/1
5 years, 5 months ago (2015-07-03 14:15:25 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 15:35:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198275

Powered by Google App Engine
This is Rietveld 408576698