Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1212403003: Use "= delete" for DISALLOW_IMPLICIT_CONSTRUCTORS. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "= delete" for DISALLOW_IMPLICIT_CONSTRUCTORS. This will guarantee the error to be at compile time, and not rely on the call visibility (private). This is part of a three-sided CL: 1. https://codereview.chromium.org/1211403004 2. <this> 3. https://codereview.chromium.org/1222143003 BUG=447156 Committed: https://crrev.com/8cd0029ed083a2d9792c7cefdcb6381eb375357f Cr-Commit-Position: refs/heads/master@{#337298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/macros.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-02 13:38:40 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-02 15:00:30 UTC) #3
Nico
Thanks for doing this!
5 years, 5 months ago (2015-07-02 15:00:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212403003/1
5 years, 5 months ago (2015-07-03 08:57:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 10:27:57 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 10:28:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cd0029ed083a2d9792c7cefdcb6381eb375357f
Cr-Commit-Position: refs/heads/master@{#337298}

Powered by Google App Engine
This is Rietveld 408576698