Issue 1211403004: Temporarily don't redefine DISALLOW_IMPLICIT_CONSTRUCTORS in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211403004: Temporarily don't redefine DISALLOW_IMPLICIT_CONSTRUCTORS in Blink. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)

Modified:
5 years, 5 months ago

Reviewers:
Erik Corry, Nico

CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Temporarily don't redefine DISALLOW_IMPLICIT_CONSTRUCTORS in Blink. It prevents build issue if the macro defined in Chromium changes. This is part of a three-sided CL: 1: <this> 2: https://codereview.chromium.org/1212403003 3: https://codereview.chromium.org/1222143003 BUG=447156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198223

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/wtf/dtoa/utils.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Dependent Patchsets:

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211403004/1

5 years, 5 months ago (2015-07-02 15:01:04 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-07-02 16:12:50 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198223