Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 12221124: Omnibox Mac: Always allow up and down arrow (Closed)

Created:
7 years, 10 months ago by sail
Modified:
7 years, 10 months ago
CC:
chromium-reviews, James Su, sail+watch_chromium.org
Visibility:
Public.

Description

Omnibox Mac: Always allow up and down arrow Currently the Mac omnibox only allows up and down arrow when the popup is open. With this CL up and down arrow work even if the popup is not open. This matches the behavior of Windows and ChromeOS. BUG=174690 TEST=Typed something in the omnibox. Clicked on the web page to close the omnibox popup. Clicked in the omnibox and pressed down arrow. Verified that the omnibox popup was displayed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181866

Patch Set 1 #

Patch Set 2 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sail
7 years, 10 months ago (2013-02-11 21:20:40 UTC) #1
Scott Hess - ex-Googler
LGTM. I vaguely recall that at one point someone wanted the standard up==home, down==end behavior, ...
7 years, 10 months ago (2013-02-11 21:31:16 UTC) #2
sail
On 2013/02/11 21:31:16, shess wrote: > LGTM. > > I vaguely recall that at one ...
7 years, 10 months ago (2013-02-11 21:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12221124/4
7 years, 10 months ago (2013-02-11 21:38:06 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=83240
7 years, 10 months ago (2013-02-12 01:51:33 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 01:55:51 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698