Omnibox Mac: Always allow up and down arrow

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
@@ skipping 687 matching lines @@
       cmd != @selector(insertTabIgnoringFieldEditor:)) {
     // Reset the suggest text for any change other than key right or tab.
     // TODO(rohitrao): This is here to prevent complications when editing text.
     // See if this can be removed.
     SetInstantSuggestion(string16());
   }
 
   if (cmd == @selector(deleteForward:))
     delete_was_pressed_ = true;
 
-  // Don't intercept up/down-arrow or backtab if the popup isn't open.
+  if (cmd == @selector(moveDown:)) {
+    model()->OnUpOrDownKeyPressed(1);
+    return true;
+  }
+
+  if (cmd == @selector(moveUp:)) {
+    model()->OnUpOrDownKeyPressed(-1);
+    return true;
+  }
+
   if (model()->popup_model()->IsOpen()) {
-    if (cmd == @selector(moveDown:)) {
-      model()->OnUpOrDownKeyPressed(1);
-      return true;
-    }
-
-    if (cmd == @selector(moveUp:)) {
-      model()->OnUpOrDownKeyPressed(-1);
-      return true;
-    }
-
-    // If instant extended is then allow users to press tab to select results
-    // from the omnibox popup.
+    // If instant extended is enabled then allow users to press tab to select
+    // results from the omnibox popup.
     BOOL enableTabAutocomplete =
         chrome::search::IsInstantExtendedAPIEnabled(model()->profile());
 
     if (cmd == @selector(insertBacktab:)) {
       if (model()->popup_model()->selected_line_state() ==
             OmniboxPopupModel::KEYWORD) {
         model()->ClearKeyword(GetText());
         return true;
       } else if (enableTabAutocomplete) {
         model()->OnUpOrDownKeyPressed(-1);
@@ skipping 307 matching lines @@
 NSUInteger OmniboxViewMac::GetTextLength() const {
   return ([field_ currentEditor] ?
           [[[field_ currentEditor] string] length] :
           [[field_ stringValue] length]) - suggest_text_length_;
 }
 
 bool OmniboxViewMac::IsCaretAtEnd() const {
   const NSRange selection = GetSelectedRange();
   return selection.length == 0 && selection.location == GetTextLength();
 }