Omnibox Mac: Always allow up and down arrow

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #include "chrome/browser/ui/omnibox/omnibox_edit_controller.h"
 #include "chrome/browser/ui/omnibox/omnibox_popup_model.h"
 #include "chrome/browser/ui/omnibox/omnibox_popup_view.h"
@@ skipping 12 matching lines @@
       : OmniboxEditModel(view, controller, profile),
         up_or_down_count_(0) {
   }
 
   virtual void OnUpOrDownKeyPressed(int count) OVERRIDE {
     up_or_down_count_ = count;
   }
 
   int up_or_down_count() const { return up_or_down_count_; }
 
+  void set_up_or_down_count(int count) {
+    up_or_down_count_ = count;
+  }
+
  private:
   int up_or_down_count_;
 
   DISALLOW_COPY_AND_ASSIGN(MockOmniboxEditModel);
 };
 
 class MockOmniboxPopupView : public OmniboxPopupView {
  public:
   MockOmniboxPopupView() : is_open_(false) {}
   virtual ~MockOmniboxPopupView() {}
@@ skipping 117 matching lines @@
   view.SetUserText(ASCIIToUTF16("Alfred"));
   EXPECT_EQ("Alfred", UTF16ToUTF8(view.GetText()));
   view.SetInstantSuggestion(ASCIIToUTF16(" Hitchcock"));
   EXPECT_EQ("Alfred", UTF16ToUTF8(view.GetText()));
   EXPECT_EQ(" Hitchcock", UTF16ToUTF8(view.GetInstantSuggestion()));
 
   view.SetUserText(string16());
   EXPECT_EQ(string16(), view.GetText());
   EXPECT_EQ(string16(), view.GetInstantSuggestion());
 }
+
+TEST_F(OmniboxViewMacTest, UpDownArrow) {
+  OmniboxViewMac view(NULL, NULL, profile(), NULL, NULL);
+
+  // This is deleted by the omnibox view.
+  MockOmniboxEditModel* model =
+      new MockOmniboxEditModel(&view, NULL, profile());
+  SetModel(&view, model);
+
+  MockOmniboxPopupView popup_view;
+  OmniboxPopupModel popup_model(&popup_view, model);
+
+  // With popup closed verify that pressing up and down arrow works.
+  popup_view.set_is_open(false);
+  model->set_up_or_down_count(0);
+  view.OnDoCommandBySelector(@selector(moveDown:));
+  EXPECT_EQ(1, model->up_or_down_count());
+  model->set_up_or_down_count(0);
+  view.OnDoCommandBySelector(@selector(moveUp:));
+  EXPECT_EQ(-1, model->up_or_down_count());
+
+  // With popup open verify that pressing up and down arrow works.
+  popup_view.set_is_open(true);
+  model->set_up_or_down_count(0);
+  view.OnDoCommandBySelector(@selector(moveDown:));
+  EXPECT_EQ(1, model->up_or_down_count());
+  model->set_up_or_down_count(0);
+  view.OnDoCommandBySelector(@selector(moveUp:));
+  EXPECT_EQ(-1, model->up_or_down_count());
+}