Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 12218116: Revert 181806 (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Revert 181806 Speculative revert to see whether this broke browser_tests on Win Aura Tests(2) A DCHECK() about invalid strings is hit > Update NetworkStateListDetailedView, add network_icon::GetImageForTray > > This integrates chanhes to the network list and icon code, > and uses the Ash icon code in the network tray. > > This completes the changes for: > 161869: Create NetworkStateHandler version of Ash network tray > (Still behind a flag) > > BUG=161869 > TBR=sky@chromium.org (for ash_strings) > > Review URL: https://codereview.chromium.org/12221112 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -732 lines) Patch
M ash/ash_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/chromeos/network/network_icon.h View 2 chunks +10 lines, -22 lines 0 comments Download
M ash/system/chromeos/network/network_icon.cc View 15 chunks +142 lines, -215 lines 0 comments Download
M ash/system/chromeos/network/network_icon_animation.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ash/system/chromeos/network/network_icon_animation.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 6 chunks +5 lines, -22 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 11 chunks +143 lines, -186 lines 0 comments Download
M ash/system/chromeos/network/tray_network.h View 3 chunks +1 line, -33 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 13 chunks +48 lines, -217 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-12 08:37:57 UTC) #1
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-12 09:53:04 UTC) #2
Message was sent while issue was closed.
seems this change was unrelated, I reverted the revert again

Powered by Google App Engine
This is Rietveld 408576698