Update Ash network icon code and integrate with tray

Update NetworkStateListDetailedView, add network_icon::GetImageForTray

This integrates chanhes to the network list and icon code, 
and uses the Ash icon code in the network tray.

This completes the changes for:
161869:	Create NetworkStateHandler version of Ash network tray
(Still behind a flag)

BUG=161869
TBR=sky@chromium.org (for ash_strings)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181806

[stevenjb, 2013-02-11 00:05:43]

OK, this code is finally ready for review (again). I separated out the
NetworkStatehandler changes into other CLs, so this one is just UI code.

[jennyz, 2013-02-11 20:23:16]

lgtm with nits.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_icon.cc (right):

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:32: 
nit: remove the extra blank line.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:72: // Sets the badges based on
|network| and the current state.
The comments looks weird, since the function name is GetXXX, but the comments
said Sets?

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:123: // a if new type gets added).
nit: "a of mew type" -> "if a new type"?

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:292: return
GetImageForIndex(image_type, icon_type, 0);
Better to add a comment to explain the disconnected image is always the very
first one in the image list.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_icon.h (right):

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:31: // show the VPN badge. This
caches badged icons per network per |icon_type|.
nit: Get->Gets.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:35: // Get the image for a connecting
network type.
ditto.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:39: // Get the image for a
disconnected network type.
ditto.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/tray_network.cc (right):

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_network.cc:163: virtual void
NetworkIconChanged() {
Is this a virtual OVERRIDE?

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_network.cc:234: virtual void
NetworkIconChanged() {
OVERRIDE?

[stevenjb, 2013-02-11 22:34:45]

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_icon.cc (right):

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:32: 
On 2013/02/11 20:23:16, jennyz wrote:
> nit: remove the extra blank line.

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:72: // Sets the badges based on
|network| and the current state.
On 2013/02/11 20:23:16, jennyz wrote:
> The comments looks weird, since the function name is GetXXX, but the comments
> said Sets?

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:123: // a if new type gets added).
On 2013/02/11 20:23:16, jennyz wrote:
> nit: "a of mew type" -> "if a new type"?

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.cc:292: return
GetImageForIndex(image_type, icon_type, 0);
On 2013/02/11 20:23:16, jennyz wrote:
> Better to add a comment to explain the disconnected image is always the very
> first one in the image list.

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_icon.h (right):

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:31: // show the VPN badge. This
caches badged icons per network per |icon_type|.
On 2013/02/11 20:23:16, jennyz wrote:
> nit: Get->Gets.

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:35: // Get the image for a connecting
network type.
On 2013/02/11 20:23:16, jennyz wrote:
> ditto.

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:39: // Get the image for a
disconnected network type.
On 2013/02/11 20:23:16, jennyz wrote:
> ditto.

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/tray_network.cc (right):

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_network.cc:163: virtual void
NetworkIconChanged() {
On 2013/02/11 20:23:16, jennyz wrote:
> Is this a virtual OVERRIDE?

Done.

https://codereview.chromium.org/12221112/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_network.cc:234: virtual void
NetworkIconChanged() {
On 2013/02/11 20:23:16, jennyz wrote:
> OVERRIDE?

Done.

[commit-bot: I haz the power, 2013-02-11 22:42:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12221112/13

[commit-bot: I haz the power, 2013-02-11 22:42:32]

Presubmit check for 12221112-13 failed and returned exit status 1.

INFO:root:Found 11 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

Presubmit checks took 3.4s to calculate.

[commit-bot: I haz the power, 2013-02-11 23:44:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12221112/13

[commit-bot: I haz the power, 2013-02-12 00:12:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.