Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: ash/system/chromeos/network/network_icon.h

Issue 12218116: Revert 181806 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash_strings.grd ('k') | ash/system/chromeos/network/network_icon.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/network/network_icon.h
===================================================================
--- ash/system/chromeos/network/network_icon.h (revision 181895)
+++ ash/system/chromeos/network/network_icon.h (working copy)
@@ -7,7 +7,6 @@
#include <string>
-#include "base/string16.h"
#include "ui/gfx/image/image_skia.h"
namespace chromeos {
@@ -19,31 +18,20 @@
class AnimationObserver;
-// Type of icon which dictates color theme and VPN badging
-enum IconType {
- ICON_TYPE_TRAY, // light icons with VPN badges
- ICON_TYPE_DEFAULT_VIEW, // dark icons with VPN badges
- ICON_TYPE_LIST, // dark icons without VPN badges
+// Color theme based on icon background.
+enum ResourceColorTheme {
+ COLOR_DARK,
+ COLOR_LIGHT,
};
-// Gets the image for the network associated with |service_path|. |network| must
-// not be NULL. |icon_type| determines the color theme and whether or not to
-// show the VPN badge. This caches badged icons per network per |icon_type|.
+// Get the image for the network associated with |service_path|.
+// |color| determines the color theme. If the icon is animating (i.e the
+// network is connecting) and |observer| is provided, it will be notified
+// when the icon changes.
gfx::ImageSkia GetImageForNetwork(const chromeos::NetworkState* network,
- IconType icon_type);
+ ResourceColorTheme color,
+ AnimationObserver* observer);
-// Gets the image for a connecting network type.
-gfx::ImageSkia GetImageForConnectingNetwork(IconType icon_type,
- const std::string& network_type);
-
-// Gets the image for a disconnected network type.
-gfx::ImageSkia GetImageForDisconnectedNetwork(IconType icon_type,
- const std::string& network_type);
-
-// Returns the label for |network| based on |icon_type|. |network| can be NULL.
-string16 GetLabelForNetwork(const chromeos::NetworkState* network,
- IconType icon_type);
-
} // namespace network_icon
} // namespace ash
« no previous file with comments | « ash/ash_strings.grd ('k') | ash/system/chromeos/network/network_icon.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698