Teach Blink's IDL parser to handle defaulted sequences of strings.

Teach Blink's IDL parser to handle defaulted sequences of strings.

It was trying to form a Vector<RefPtr<String>>, which doesn't work.

BUG=500638
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198034

[Jeffrey Yasskin, 2015-06-29 23:26:28]

jyasskin@chromium.org changed reviewers:
+ bashi@chromium.org, scheib@chromium.org

[Jeffrey Yasskin, 2015-06-29 23:26:29]

https://codereview.chromium.org/1221743002/diff/20001/Source/bindings/tests/i...
File Source/bindings/tests/idls/core/TestDictionary.idl (right):

https://codereview.chromium.org/1221743002/diff/20001/Source/bindings/tests/i...
Source/bindings/tests/idls/core/TestDictionary.idl:20: sequence<DOMString>
stringSequenceMember = [];
I can add a separate member if this one needs to test the non-defaulted case.

https://codereview.chromium.org/1221743002/diff/20001/Source/bindings/tests/r...
File Source/bindings/tests/results/core/TestDictionary.cpp (right):

https://codereview.chromium.org/1221743002/diff/20001/Source/bindings/tests/r...
Source/bindings/tests/results/core/TestDictionary.cpp:23:
setTestInterfaceSequenceMember(Vector<RefPtr<TestInterfaceImplementation>>());
I think this is more correct. TestInterface is
ImplementedAs=TestInterfaceImplementation
(https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKi...),
so no TestInterface class will exist in C++, right?

[Jeffrey Yasskin, 2015-06-29 23:26:56]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-29 23:27:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221743002/20001

[bashi, 2015-06-29 23:42:34]

Thanks for fixing this!

Could you also add a test case for
LayoutTests/fast/dom/idl-dictionary-unittest.html?
You would need to modify Source/core/testing/InternalDictionary.idl and
Source/core/testing/DictionaryTest.{cpp,h}

[scheib, 2015-06-29 23:57:44]

Source/modules/bluetooth/RequestDeviceOptions.idl LGTM

[commit-bot: I haz the power, 2015-06-30 00:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 00:51:23]

Dry run: This issue passed the CQ dry run.

[Jeffrey Yasskin, 2015-06-30 01:10:12]

On 2015/06/29 23:42:34, bashi1 wrote:
> Thanks for fixing this!
> 
> Could you also add a test case for
> LayoutTests/fast/dom/idl-dictionary-unittest.html?
> You would need to modify Source/core/testing/InternalDictionary.idl and
> Source/core/testing/DictionaryTest.{cpp,h}

Done, thanks.

[bashi, 2015-06-30 01:12:40]

LGTM

[Jeffrey Yasskin, 2015-06-30 01:18:42]

The CQ bit was checked by jyasskin@chromium.org

[Jeffrey Yasskin, 2015-06-30 01:18:42]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1221743002/#ps40001
(title: "Add a test to LayoutTests/fast/dom/idl-dictionary-unittest.html")

[commit-bot: I haz the power, 2015-06-30 01:18:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221743002/40001

[commit-bot: I haz the power, 2015-06-30 01:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 01:26:05]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[Jeffrey Yasskin, 2015-06-30 01:28:26]

jyasskin@chromium.org changed reviewers:
+ haraken@chromium.org

[Jeffrey Yasskin, 2015-06-30 01:28:27]

haraken, can you check Source/core/testing?

[haraken, 2015-06-30 02:36:28]

LGTM

[haraken, 2015-06-30 02:36:34]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-06-30 02:36:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221743002/40001

[commit-bot: I haz the power, 2015-06-30 03:22:32]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198034