Source/bindings/scripts/v8_types.py - Issue 1221743002: Teach Blink's IDL parser to handle defaulted sequences of strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 1221743002: Teach Blink's IDL parser to handle defaulted sequences of strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned

Patch Set: Add a test to LayoutTests/fast/dom/idl-dictionary-unittest.html Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt ('k') | Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index d1dfb9f631a1193524bea2d4f4caad99f6b3f729..3272b297cb642adae4f0699e642618d43089b31b 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -938,12 +938,7 @@ def union_literal_cpp_value(idl_type, idl_literal):

def array_or_sequence_literal_cpp_value(idl_type, idl_literal):

# Only support empty arrays.

if idl_literal.value == '[]':

- element_type = idl_type.element_type

- ref_ptr_type = cpp_ptr_type('RefPtr', 'Member', element_type.gc_type)

- inner_type = cpp_template_type(ref_ptr_type, element_type.name)

- vector_type = cpp_ptr_type('Vector', 'HeapVector',

- element_type.gc_type)

- return cpp_template_type(vector_type, inner_type) + '()'

+ return cpp_type(idl_type) + '()'

raise ValueError('Unsupported literal type: ' + idl_literal.idl_type)

« no previous file with comments | « LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt ('k') | Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »