Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: LayoutTests/fast/dom/idl-dictionary-unittest.html

Issue 1221743002: Teach Blink's IDL parser to handle defaulted sequences of strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned
Patch Set: Add a test to LayoutTests/fast/dom/idl-dictionary-unittest.html Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/idl-dictionary-unittest.html
diff --git a/LayoutTests/fast/dom/idl-dictionary-unittest.html b/LayoutTests/fast/dom/idl-dictionary-unittest.html
index b396eec605e8109cd2068369075826213a44a771..b98f08d0b0189ef8d5b96ff1c5d9a580eac91898 100644
--- a/LayoutTests/fast/dom/idl-dictionary-unittest.html
+++ b/LayoutTests/fast/dom/idl-dictionary-unittest.html
@@ -24,6 +24,7 @@ if (window.internals && internals.dictionaryTest) {
shouldBeUndefined('dict.byteStringMember');
shouldBeUndefined('dict.usvStringMember');
shouldBeUndefined('dict.stringSequenceMember');
+ shouldBe('dict.stringSequenceMemberWithDefault', '[]');
shouldBeUndefined('dict.stringSequenceOrNullMember');
shouldBeUndefined('dict.elementMember');
shouldBeUndefined('dict.elementOrNullMember');
@@ -52,6 +53,7 @@ if (window.internals && internals.dictionaryTest) {
shouldBeUndefined('dict.usvStringMember');
shouldBeEqualToString('dict.stringMemberWithDefault', 'defaultStringValue');
shouldBeUndefined('dict.stringSequenceMember');
+ shouldBe('dict.stringSequenceMemberWithDefault', '[]');
shouldBeUndefined('dict.stringSequenceOrNullMember');
shouldBeUndefined('dict.elementMember');
shouldBeUndefined('dict.elementOrNullMember');
@@ -76,6 +78,7 @@ if (window.internals && internals.dictionaryTest) {
doubleMember: 3.14,
unrestrictedDoubleMember: NaN,
stringSequenceMember: ['foo', 'bar', 'baz'],
+ stringSequenceMemberWithDefault: ['foo', 'bar', 'baz'],
stringSequenceOrNullMember: [],
elementMember: element1,
elementOrNullMember: null,
@@ -101,6 +104,7 @@ if (window.internals && internals.dictionaryTest) {
shouldBe('dict.doubleMember', '3.14');
shouldBe('dict.unrestrictedDoubleMember', 'NaN');
shouldBe('dict.stringSequenceMember', '["foo", "bar", "baz"]');
+ shouldBe('dict.stringSequenceMemberWithDefault', '["foo", "bar", "baz"]');
shouldBe('dict.stringSequenceOrNullMember', '[]');
shouldBe('dict.elementMember', 'element1');
// This will be undefined as the spec says
@@ -258,6 +262,7 @@ if (window.internals && internals.dictionaryTest) {
shouldBeUndefined('derived.stringMember');
shouldBeEqualToString('derived.stringMemberWithDefault', 'defaultStringValue');
shouldBeUndefined('derived.stringSequenceMember');
+ shouldBe('derived.stringSequenceMemberWithDefault', '[]');
shouldBeUndefined('derived.stringSequenceOrNullMember');
shouldBeUndefined('derived.elementMember');
shouldBeUndefined('derived.elementOrNullMember');
« no previous file with comments | « no previous file | LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698