Distinguish slow from fast sloppy arguments

Distinguish slow from fast sloppy arguments

BUG=v8:4137
LOG=n

Committed: https://crrev.com/c8211b64cdee1dc71fa91945c8e5fa9880fcee2f
Cr-Commit-Position: refs/heads/master@{#29447}

[Toon Verwaest, 2015-06-30 15:53:02]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-06-30 15:53:03]

ptal

[Igor Sheludko, 2015-07-02 13:28:43]

You should probably also update Map::ReconfigureProperty() to handle
SLOW_SLOPPY_ARGUMENTS_ELEMENTS kind the same way as DICTIONARY_ELEMENTS in order
to leave it in sync with Map::TryUpdate().

Probably all the friend class declarations do not make sense here anymore. These
implementation classes are not visible outside elements.cc anyway. What about
making all the protected sections public?

https://codereview.chromium.org/1221713003/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1221713003/diff/20001/src/elements.cc#newcode...
src/elements.cc:1735: FastHoleyObjectElementsAccessor::DeleteCommon(obj, key,
language_mode);
You can put the implementation of this to the parent if you use 
ArgumentsAccessor::DeleteCommon(obj, key, language_mode);

https://codereview.chromium.org/1221713003/diff/20001/src/elements.h
File src/elements.h (right):

https://codereview.chromium.org/1221713003/diff/20001/src/elements.h#newcode24
src/elements.h:24: class SloppyArgumentsElementsAccessor;
These declarations should not be here.

https://codereview.chromium.org/1221713003/diff/20001/src/elements.h#newcode168
src/elements.h:168: ElementsKindTraits<SLOW_SLOPPY_ARGUMENTS_ELEMENTS> >;
These friend declarations should not be here. You can move them to
ElementsAccessorBase<>.

https://codereview.chromium.org/1221713003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1221713003/diff/20001/src/objects.cc#newcode3721
src/objects.cc:3721: allow_store_transition &=
allow_store_transition = allow_store_transition &&

https://codereview.chromium.org/1221713003/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1221713003/diff/20001/src/objects.h#newcode5705
src/objects.h:5705: return elements_kind() == FAST_SLOPPY_ARGUMENTS_ELEMENTS ||
return IsSloppyArgumentsElements(elements_kind());

[Toon Verwaest, 2015-07-02 13:49:02]

Addressed comments, thanks for the review and hints!

https://codereview.chromium.org/1221713003/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1221713003/diff/20001/src/elements.cc#newcode...
src/elements.cc:1735: FastHoleyObjectElementsAccessor::DeleteCommon(obj, key,
language_mode);
On 2015/07/02 13:28:42, Igor Sheludko wrote:
> You can put the implementation of this to the parent if you use 
> ArgumentsAccessor::DeleteCommon(obj, key, language_mode);

Done.

https://codereview.chromium.org/1221713003/diff/20001/src/elements.h
File src/elements.h (right):

https://codereview.chromium.org/1221713003/diff/20001/src/elements.h#newcode24
src/elements.h:24: class SloppyArgumentsElementsAccessor;
On 2015/07/02 13:28:42, Igor Sheludko wrote:
> These declarations should not be here.

Done.

https://codereview.chromium.org/1221713003/diff/20001/src/elements.h#newcode168
src/elements.h:168: ElementsKindTraits<SLOW_SLOPPY_ARGUMENTS_ELEMENTS> >;
On 2015/07/02 13:28:42, Igor Sheludko wrote:
> These friend declarations should not be here. You can move them to
> ElementsAccessorBase<>.

Done.

https://codereview.chromium.org/1221713003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1221713003/diff/20001/src/objects.cc#newcode3721
src/objects.cc:3721: allow_store_transition &=
On 2015/07/02 13:28:42, Igor Sheludko wrote:
> allow_store_transition = allow_store_transition &&

Done.

https://codereview.chromium.org/1221713003/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1221713003/diff/20001/src/objects.h#newcode5705
src/objects.h:5705: return elements_kind() == FAST_SLOPPY_ARGUMENTS_ELEMENTS ||
On 2015/07/02 13:28:42, Igor Sheludko wrote:
> return IsSloppyArgumentsElements(elements_kind());

Done.

[Igor Sheludko, 2015-07-02 14:09:38]

lgtm

[Toon Verwaest, 2015-07-02 14:09:51]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-07-02 14:10:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221713003/60001

[commit-bot: I haz the power, 2015-07-02 14:38:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-02 14:39:00]

Patchset 4 (id:??) landed as
https://crrev.com/c8211b64cdee1dc71fa91945c8e5fa9880fcee2f
Cr-Commit-Position: refs/heads/master@{#29447}