Distinguish slow from fast sloppy arguments

src/elements.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ELEMENTS_H_
 #define V8_ELEMENTS_H_
 
 #include "src/elements-kind.h"
 #include "src/heap/heap.h"
 #include "src/isolate.h"
 #include "src/objects.h"
 
 namespace v8 {
 namespace internal {
 
+class FastHoleyObjectElementsAccessor;
+class DictionaryElementsAccessor;
+class FastSloppyArgumentsElementsAccessor;
+class SlowSloppyArgumentsElementsAccessor;
+template <ElementsKind Kind>
+class ElementsKindTraits;
+template <typename SloppyArgumentsElementsAccessorSubclass,
+          typename ArgumentsAccessor, typename KindTraits>
+class SloppyArgumentsElementsAccessor;

[Igor Sheludko, 2015/07/02 13:28:42]

These declarations should not be here.

[Toon Verwaest, 2015/07/02 13:49:02]

Done.

+
 // Abstract base class for handles that can operate on objects with differing
 // ElementsKinds.
 class ElementsAccessor {
  public:
   explicit ElementsAccessor(const char* name) : name_(name) { }
   virtual ~ElementsAccessor() { }
 
   const char* name() const { return name_; }
 
   // Checks the elements of an object for consistency, asserting when a problem
@@ skipping 116 matching lines @@
                    Object* value) = 0;
   virtual void Reconfigure(Handle<JSObject> object,
                            Handle<FixedArrayBase> backing_store, uint32_t index,
                            Handle<Object> value,
                            PropertyAttributes attributes) = 0;
   virtual void Add(Handle<JSObject> object, uint32_t index,
                    Handle<Object> value, PropertyAttributes attributes,
                    uint32_t new_capacity) = 0;
 
  protected:
-  friend class SloppyArgumentsElementsAccessor;
   friend class LookupIterator;
+  friend class SloppyArgumentsElementsAccessor<
+      FastSloppyArgumentsElementsAccessor, FastHoleyObjectElementsAccessor,
+      ElementsKindTraits<FAST_SLOPPY_ARGUMENTS_ELEMENTS> >;
+  friend class SloppyArgumentsElementsAccessor<
+      SlowSloppyArgumentsElementsAccessor, DictionaryElementsAccessor,
+      ElementsKindTraits<SLOW_SLOPPY_ARGUMENTS_ELEMENTS> >;

[Igor Sheludko, 2015/07/02 13:28:42]

These friend declarations should not be here. You can move them to
ElementsAccessorBase<>.

[Toon Verwaest, 2015/07/02 13:49:02]

Done.

 
   static ElementsAccessor* ForArray(FixedArrayBase* array);
 
   virtual uint32_t GetCapacity(JSObject* holder,
                                FixedArrayBase* backing_store) = 0;
 
   // Element handlers distinguish between indexes and keys when they manipulate
   // elements.  Indexes refer to elements in terms of their location in the
   // underlying storage's backing store representation, and are between 0 and
   // GetCapacity.  Keys refer to elements in terms of the value that would be
@@ skipping 20 matching lines @@
 void CheckArrayAbuse(Handle<JSObject> obj, const char* op, uint32_t key,
                      bool allow_appending = false);
 
 MUST_USE_RESULT MaybeHandle<Object> ArrayConstructInitializeElements(
     Handle<JSArray> array,
     Arguments* args);
 
 } }  // namespace v8::internal
 
 #endif  // V8_ELEMENTS_H_