Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: src/ic/ic-compiler.cc

Issue 1221713003: Distinguish slow from fast sloppy arguments (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/cpu-profiler.h" 7 #include "src/cpu-profiler.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic-inl.h" 9 #include "src/ic/ic-inl.h"
10 #include "src/ic/ic-compiler.h" 10 #include "src/ic/ic-compiler.h"
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 340
341 Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic( 341 Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic(
342 MapHandleList* receiver_maps, KeyedAccessStoreMode store_mode) { 342 MapHandleList* receiver_maps, KeyedAccessStoreMode store_mode) {
343 // Collect MONOMORPHIC stubs for all |receiver_maps|. 343 // Collect MONOMORPHIC stubs for all |receiver_maps|.
344 CodeHandleList handlers(receiver_maps->length()); 344 CodeHandleList handlers(receiver_maps->length());
345 MapHandleList transitioned_maps(receiver_maps->length()); 345 MapHandleList transitioned_maps(receiver_maps->length());
346 for (int i = 0; i < receiver_maps->length(); ++i) { 346 for (int i = 0; i < receiver_maps->length(); ++i) {
347 Handle<Map> receiver_map(receiver_maps->at(i)); 347 Handle<Map> receiver_map(receiver_maps->at(i));
348 Handle<Code> cached_stub; 348 Handle<Code> cached_stub;
349 Handle<Map> transitioned_map = 349 Handle<Map> transitioned_map =
350 receiver_map->FindTransitionedMap(receiver_maps); 350 Map::FindTransitionedMap(receiver_map, receiver_maps);
351 351
352 // TODO(mvstanton): The code below is doing pessimistic elements 352 // TODO(mvstanton): The code below is doing pessimistic elements
353 // transitions. I would like to stop doing that and rely on Allocation Site 353 // transitions. I would like to stop doing that and rely on Allocation Site
354 // Tracking to do a better job of ensuring the data types are what they need 354 // Tracking to do a better job of ensuring the data types are what they need
355 // to be. Not all the elements are in place yet, pessimistic elements 355 // to be. Not all the elements are in place yet, pessimistic elements
356 // transitions are still important for performance. 356 // transitions are still important for performance.
357 bool is_js_array = receiver_map->instance_type() == JS_ARRAY_TYPE; 357 bool is_js_array = receiver_map->instance_type() == JS_ARRAY_TYPE;
358 ElementsKind elements_kind = receiver_map->elements_kind(); 358 ElementsKind elements_kind = receiver_map->elements_kind();
359 if (!transitioned_map.is_null()) { 359 if (!transitioned_map.is_null()) {
360 cached_stub = 360 cached_stub =
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 414
415 TailCallBuiltin(masm(), Builtins::kKeyedStoreIC_Miss); 415 TailCallBuiltin(masm(), Builtins::kKeyedStoreIC_Miss);
416 416
417 return GetCode(kind(), Code::NORMAL, factory()->empty_string()); 417 return GetCode(kind(), Code::NORMAL, factory()->empty_string());
418 } 418 }
419 419
420 420
421 #undef __ 421 #undef __
422 } // namespace internal 422 } // namespace internal
423 } // namespace v8 423 } // namespace v8
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698