Issue 1221693004: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221693004: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (4) (Closed)

Created:
5 years, 5 months ago by nhiroki

Modified:
5 years, 5 months ago

Reviewers:
haraken, yhirano

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@cbadapter2

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (4) CallbackPromiseAdapter is designed to take ownership of a passed object. See comments in CallbackPromiseAdapter.h for details. (1) Chromium: https://codereview.chromium.org/1217633003/ (2) Blink: https://codereview.chromium.org/1211353004/ (3) Chromium: https://codereview.chromium.org/1225543002/ (4) Blink: THIS PATCH BUG=493531

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	Source/bindings/core/v8/CallbackPromiseAdapter.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Depends on Patchset:

Total messages: 6 (1 generated)

nhiroki

Thank you for reviewing! On 2015/07/03 07:36:07, haraken wrote: > LGTM, sorry about the noise. ...

5 years, 5 months ago (2015-07-03 07:47:06 UTC) #5

I'll close this (see CL(2))