Source/bindings/core/v8/CallbackPromiseAdapter.h - Issue 1221693004: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1221693004: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (4) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cbadapter2

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/CallbackPromiseAdapter.h

diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h

index 205e04c06d308b5dda1dce74a6645662a242fe02..786961a24e81130c17869fd2c43d86a3f5029bc3 100644

--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h

+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h

@@ -36,10 +36,6 @@

namespace blink {

-// TODO(nhiroki): Remove ifdef hack after Chromium-side patch is landed.

-// http://crbug.com/493531

-#define CRBUG_493531

// This class provides an easy way to convert from a Script-exposed

// class (i.e. a class that has a toV8() overload) that uses Promises

// to a WebKit API class that uses WebCallbacks. You can define

« no previous file with comments | « no previous file | no next file » | no next file with comments »